From 8bac35ae2a1b466e0cb30d0effb35e660f6a9818 Mon Sep 17 00:00:00 2001
From: Dhilan007 <wenhai.lin@chukong-inc.com>
Date: Mon, 10 Mar 2014 19:42:43 +0800
Subject: [PATCH 1/4] closed #4337:label support create by font name,compatible
 with old labelTTF.

---
 cocos/2d/CCLabel.cpp                          | 321 +++++++++++++++---
 cocos/2d/CCLabel.h                            |  59 +++-
 .../Classes/LabelTest/LabelTestNew.cpp        |  49 ++-
 .../Classes/LabelTest/LabelTestNew.h          |  11 +
 4 files changed, 372 insertions(+), 68 deletions(-)

diff --git a/cocos/2d/CCLabel.cpp b/cocos/2d/CCLabel.cpp
index 24d6e1cb11..16623d7b2e 100644
--- a/cocos/2d/CCLabel.cpp
+++ b/cocos/2d/CCLabel.cpp
@@ -50,6 +50,54 @@ Label* Label::create()
     return ret;
 }
 
+Label* Label::createWithFontDefinition(const std::string& text, FontDefinition &textDefinition)
+{
+    auto ret = new Label();
+
+    if (ret)
+    {
+        ret->setFontDefinition(textDefinition);
+        ret->setString(text);
+        ret->autorelease();
+    }
+
+    return ret;
+}
+
+Label* Label::create(const std::string& text, const std::string& fontName, float fontSize, const Size& dimensions /* = Size::ZERO */, TextHAlignment hAlignment /* = TextHAlignment::LEFT */, TextVAlignment vAlignment /* = TextVAlignment::TOP */)
+{
+    auto ret = new Label(nullptr,hAlignment);
+
+    if (ret)
+    {
+        do 
+        {
+            if (fontName.find('.') != fontName.npos)
+            {
+                TTFConfig ttfConfig(fontName.c_str(),fontSize,GlyphCollection::DYNAMIC);
+                if (ret->setTTFConfig(ttfConfig))
+                {
+                    break;
+                }
+            }
+
+            FontDefinition fontDef;
+            fontDef._fontName = fontName;
+            fontDef._fontSize = fontSize;
+            fontDef._dimensions = dimensions;
+            fontDef._alignment = hAlignment;
+            fontDef._vertAlignment = vAlignment;
+            ret->setFontDefinition(fontDef);
+        } while (0);
+
+        ret->setDimensions(dimensions.width,dimensions.height);
+        ret->setString(text);
+        ret->autorelease();
+    }   
+
+    return ret;
+}
+
 Label* Label::createWithTTF(const TTFConfig& ttfConfig, const std::string& text, TextHAlignment alignment /* = TextHAlignment::CENTER */, int lineSize /* = 0 */)
 {
     Label *ret = new Label(nullptr,alignment);
@@ -162,7 +210,13 @@ bool Label::setCharMap(const std::string& plistFile)
     if (!newAtlas)
         return false;
 
-    return initWithFontAtlas(newAtlas);
+    if (initWithFontAtlas(newAtlas))
+    {
+        _currLabelType = LabelType::TypeCHARMAP;
+        return true;
+    }
+
+    return false;
 }
 
 bool Label::setCharMap(Texture2D* texture, int itemWidth, int itemHeight, int startCharMap)
@@ -172,7 +226,13 @@ bool Label::setCharMap(Texture2D* texture, int itemWidth, int itemHeight, int st
     if (!newAtlas)
         return false;
 
-    return initWithFontAtlas(newAtlas);
+    if (initWithFontAtlas(newAtlas))
+    {
+        _currLabelType = LabelType::TypeCHARMAP;
+        return true;
+    }
+
+    return false;
 }
 
 bool Label::setCharMap(const std::string& charMapFile, int itemWidth, int itemHeight, int startCharMap)
@@ -182,7 +242,13 @@ bool Label::setCharMap(const std::string& charMapFile, int itemWidth, int itemHe
     if (!newAtlas)
         return false;
 
-    return initWithFontAtlas(newAtlas);
+    if (initWithFontAtlas(newAtlas))
+    {
+        _currLabelType = LabelType::TypeCHARMAP;
+        return true;
+    }
+
+    return false;
 }
 
 Label::Label(FontAtlas *atlas, TextHAlignment alignment, bool useDistanceField,bool useA8Shader)
@@ -203,9 +269,16 @@ Label::Label(FontAtlas *atlas, TextHAlignment alignment, bool useDistanceField,b
 , _fontScale(1.0f)
 , _uniformEffectColor(0)
 ,_currNumLines(-1)
+,_textSprite(nullptr)
+,_contentDirty(false)
 {
     _cascadeColorEnabled = true;
     _batchNodes.push_back(this);
+
+    _fontDefinition._fontName = "Helvetica";
+    _fontDefinition._fontSize = 32;
+    _fontDefinition._alignment = TextHAlignment::LEFT;
+    _fontDefinition._vertAlignment = TextVAlignment::TOP;
 }
 
 Label::~Label()
@@ -301,11 +374,7 @@ bool Label::initWithFontAtlas(FontAtlas* atlas,bool distanceFieldEnabled /* = fa
     if (_fontAtlas)
     {
         _commonLineHeight = _fontAtlas->getCommonLineHeight();
-        if(_currentUTF16String)
-        {
-            resetCurrentString();
-            alignText();
-        }
+        _contentDirty = true;
     }
 
     return ret;
@@ -333,6 +402,7 @@ bool Label::setTTFConfig(const TTFConfig& ttfConfig)
         {
             this->setFontScale(1.0f * ttfConfig.fontSize / DefultFontSize);
         }
+        _currLabelType = LabelType::TypeTTF;
         return true;
     }
     else
@@ -348,47 +418,54 @@ bool Label::setBMFontFilePath(const std::string& bmfontFilePath, const Point& im
     if (!newAtlas)
         return false;
 
-    return initWithFontAtlas(newAtlas);
-}
-
-void Label::setString(const std::string& text)
-{
-    auto utf16String = cc_utf8_to_utf16(text.c_str());
-    if(utf16String)
+    if (initWithFontAtlas(newAtlas))
     {
-        _originalUTF8String = text;
-        setCurrentString(utf16String);
-        setOriginalString(utf16String);
-        alignText();
+        _currLabelType = LabelType::TypeBMFONT;
+        return true;
     }
+
+    return false;
 }
 
-void Label::setAlignment(TextHAlignment hAlignment,bool aligntext /* = true */)
+inline void Label::setFontDefinition(const FontDefinition& textDefinition)
 {
-    setAlignment(hAlignment,_vAlignment,aligntext);
+    _fontDefinition = textDefinition;
+    _currLabelType = LabelType::TypeSPRITE;
+    _contentDirty = true;
 }
 
-inline void Label::setHorizontalAlignment(TextHAlignment hAlignment,bool aligntext /* = true */)
+inline void Label::setString(const std::string& text)
 {
-    setAlignment(hAlignment,_vAlignment,aligntext);
+    _originalUTF8String = text;
+    _contentDirty = true;
 }
 
-inline void Label::setVerticalAlignment(TextVAlignment vAlignment,bool aligntext /* = true */)
+void Label::setAlignment(TextHAlignment hAlignment)
 {
-    setAlignment(_hAlignment,vAlignment,aligntext);
+    setAlignment(hAlignment,_vAlignment);
 }
 
-void Label::setAlignment(TextHAlignment hAlignment,TextVAlignment vAlignment,bool aligntext /* = true */)
+inline void Label::setHorizontalAlignment(TextHAlignment hAlignment)
+{
+    setAlignment(hAlignment,_vAlignment);
+}
+
+inline void Label::setVerticalAlignment(TextVAlignment vAlignment)
+{
+    setAlignment(_hAlignment,vAlignment);
+}
+
+void Label::setAlignment(TextHAlignment hAlignment,TextVAlignment vAlignment)
 {
     if (hAlignment != _hAlignment || vAlignment != _vAlignment)
     {
+        _fontDefinition._alignment = hAlignment;
+        _fontDefinition._vertAlignment = vAlignment;
+
         _hAlignment = hAlignment;
         _vAlignment = vAlignment;
-        if (_currentUTF16String && aligntext)
-        {
-            resetCurrentString();
-            alignText();
-        }
+
+        _contentDirty = true;
     }
 }
 
@@ -397,11 +474,7 @@ void Label::setMaxLineWidth(unsigned int maxLineWidth)
     if (_maxLineWidth != maxLineWidth)
     {
         _maxLineWidth = maxLineWidth;
-        if (_currentUTF16String)
-        {
-            resetCurrentString();
-            alignText();
-        }
+        _contentDirty = true;
     }
 }
 
@@ -419,15 +492,14 @@ void Label::setDimensions(unsigned int width,unsigned int height)
 {
     if (height != _labelHeight || width != _labelWidth)
     {
+        _fontDefinition._dimensions.width = width;
+        _fontDefinition._dimensions.height = height;
+
         _labelHeight = height;
         _labelWidth = width;
         _maxLineWidth = width;
-        if (_currentUTF16String)
-        {
-            resetCurrentString();
-            alignText();
-        }
-    }
+        _contentDirty = true;
+    }  
 }
 
 void Label::setLineBreakWithoutSpace(bool breakWithoutSpace)
@@ -613,7 +685,11 @@ bool Label::setCurrentString(unsigned short *stringToSet)
     computeStringNumLines();
 
     // compute the advances
-    return computeHorizontalKernings(stringToSet);
+    if (_fontAtlas)
+    {
+        computeHorizontalKernings(stringToSet);
+    }
+    return true;
 }
 
 void Label::resetCurrentString()
@@ -716,16 +792,26 @@ void Label::enableGlow(const Color3B& glowColor)
 void Label::enableOutline(const Color4B& outlineColor,int outlineSize /* = 1 */)
 {
     _outlineColor = outlineColor;
+
     if (outlineSize > 0)
     {
-        _currLabelEffect = LabelEffect::OUTLINE;
-        if (_fontConfig.outlineSize != outlineSize)
+        if (_currLabelType == LabelType::TypeTTF)
         {
-            _fontConfig.outlineSize = outlineSize;
-            setTTFConfig(_fontConfig);
+            if (_fontConfig.outlineSize != outlineSize)
+            { 
+                auto config = _fontConfig;
+                config.outlineSize = outlineSize;
+                setTTFConfig(config);
+                initProgram();
+            }
         }
-       initProgram();
-    } 
+        _fontDefinition._stroke._strokeEnabled = true;
+        _fontDefinition._stroke._strokeSize = outlineSize;
+        _fontDefinition._stroke._strokeColor = Color3B(outlineColor.r,outlineColor.g,outlineColor.b);
+
+        _currLabelEffect = LabelEffect::OUTLINE;
+        _contentDirty = true;
+    }
 }
 
 void Label::enableShadow(const Color3B& shadowColor /* = Color3B::BLACK */,const Size &offset /* = Size(2 ,-2)*/, float opacity /* = 0.75f */, int blurRadius /* = 0 */)
@@ -736,6 +822,13 @@ void Label::enableShadow(const Color3B& shadowColor /* = Color3B::BLACK */,const
     //todo:support blur for shadow
     _shadowBlurRadius = 0;
     _currLabelEffect = LabelEffect::SHADOW;
+
+    _fontDefinition._shadow._shadowEnabled = true;
+    _fontDefinition._shadow._shadowBlur = blurRadius;
+    _fontDefinition._shadow._shadowOffset = offset;
+    _fontDefinition._shadow._shadowOpacity = opacity;
+
+    _contentDirty = true;
 }
 
 void Label::disableEffect()
@@ -747,6 +840,7 @@ void Label::disableEffect()
     }
     _currLabelEffect = LabelEffect::NORMAL;
     initProgram();
+    _contentDirty = true;
 }
 
 void Label::setFontScale(float fontScale)
@@ -845,14 +939,61 @@ void Label::draw(Renderer *renderer, const kmMat4 &transform, bool transformUpda
     renderer->addCommand(&_customCommand);
 }
 
+void Label::createSpriteWithFontDefinition()
+{
+    _currLabelType = LabelType::TypeSPRITE;
+    auto texture = new Texture2D;
+#if (CC_TARGET_PLATFORM != CC_PLATFORM_ANDROID) && (CC_TARGET_PLATFORM != CC_PLATFORM_IOS)
+    if (_fontDefinition._shadow._shadowEnabled || _fontDefinition._stroke._strokeEnabled)
+    {
+        CCLOGERROR("Currently only supported on iOS and Android!");
+    }
+    _fontDefinition._shadow._shadowEnabled = false;
+    _fontDefinition._stroke._strokeEnabled = false;
+#endif
+    texture->initWithString(_originalUTF8String.c_str(),_fontDefinition);
+
+    _textSprite = Sprite::createWithTexture(texture);
+    _textSprite->setAnchorPoint(Point::ANCHOR_BOTTOM_LEFT);
+    this->setContentSize(_textSprite->getContentSize());
+    texture->release();
+
+    Node::addChild(_textSprite,0,Node::INVALID_TAG);
+}
+
+void Label::updateContent()
+{
+    auto utf16String = cc_utf8_to_utf16(_originalUTF8String.c_str());
+    setCurrentString(utf16String);
+    setOriginalString(utf16String);
+    if (_textSprite)
+    {
+        _textSprite->removeFromParent();
+        _textSprite = nullptr;
+    }
+    if (_fontAtlas)
+    {
+        alignText();
+    }
+    else
+    {
+        createSpriteWithFontDefinition();
+    }
+    _contentDirty = false;
+}
+
 void Label::visit(Renderer *renderer, const kmMat4 &parentTransform, bool parentTransformUpdated)
 {
     if (! _visible)
     {
         return;
     }
+    if (_contentDirty)
+    {
+        updateContent();
+    }
 
-    if (_currLabelEffect == LabelEffect::SHADOW && _shadowBlurRadius <= 0)
+    if (! _textSprite && _currLabelEffect == LabelEffect::SHADOW && _shadowBlurRadius <= 0)
     {
         _parentTransform = parentTransform;
         draw(renderer, _modelViewTransform, true);
@@ -871,7 +1012,14 @@ void Label::visit(Renderer *renderer, const kmMat4 &parentTransform, bool parent
         kmGLPushMatrix();
         kmGLLoadMatrix(&_modelViewTransform);
 
-        draw(renderer, _modelViewTransform, dirty);
+        if (_textSprite)
+        {
+            _textSprite->visit();
+        }
+        else
+        {
+            draw(renderer, _modelViewTransform, dirty);
+        }
 
         kmGLPopMatrix();
     }
@@ -879,10 +1027,60 @@ void Label::visit(Renderer *renderer, const kmMat4 &parentTransform, bool parent
     setOrderOfArrival(0);
 }
 
+void Label::setFontName(const std::string& fontName)
+{
+    _fontDefinition._fontName = fontName;
+    if (fontName.find('.') != fontName.npos)
+    {
+        auto config = _fontConfig;
+        config.fontFilePath = fontName;
+        setTTFConfig(config);
+    }
+    _contentDirty = true;
+}
+
+inline const std::string& Label::getFontName() const
+{
+    return _fontDefinition._fontName;
+}
+
+void Label::setFontSize(int fontSize)
+{
+    if (_currLabelType == LabelType::TypeTTF)
+    {
+        if (_fontConfig.distanceFieldEnabled == true)
+        {
+            _fontConfig.fontSize = fontSize;
+            this->setFontScale(1.0f * fontSize / DefultFontSize);
+        }
+        else
+        {
+            auto fontConfig = _fontConfig;
+            fontConfig.fontSize = fontSize;
+            setTTFConfig(fontConfig);
+        }
+    }
+    else
+    {
+        _fontDefinition._fontSize = fontSize;
+        _fontConfig.fontSize = fontSize;
+        _contentDirty = true;
+    }
+}
+
+inline int Label::getFontSize() const
+{
+    return _fontDefinition._fontSize;
+}
 ///// PROTOCOL STUFF
 Sprite * Label::getLetter(int lettetIndex)
 {
-    if (lettetIndex < _limitShowCount)
+    if (_contentDirty)
+    {
+        updateContent();
+    }
+    
+    if (! _textSprite && lettetIndex < _limitShowCount)
     {
         if(_lettersInfo[lettetIndex].def.validDefinition == false)
             return nullptr;
@@ -913,11 +1111,11 @@ Sprite * Label::getLetter(int lettetIndex)
 
 int Label::getCommonLineHeight() const
 {
-    return _commonLineHeight;
+    return _textSprite ? 0 : _commonLineHeight;
 }
 
 // string related stuff
-int Label::getStringNumLines() const
+inline int Label::getStringNumLines() const
 {
     return _currNumLines;
 }
@@ -951,7 +1149,7 @@ int Label::getStringLength() const
 }
 
 // RGBA protocol
-bool Label::isOpacityModifyRGB() const
+inline bool Label::isOpacityModifyRGB() const
 {
     return _isOpacityModifyRGB;
 }
@@ -969,6 +1167,11 @@ void Label::setOpacityModifyRGB(bool isOpacityModifyRGB)
 
 void Label::setColor(const Color3B& color)
 {
+    _fontDefinition._fontFillColor = color;
+    if (_textSprite)
+    {
+        updateContent();
+    }
     _reusedLetter->setColor(color);
     SpriteBatchNode::setColor(color);
 }
@@ -1014,4 +1217,12 @@ std::string Label::getDescription() const
     return StringUtils::format("<Label | Tag = %d, Label = '%s'>", _tag, cc_utf16_to_utf8(_currentUTF16String,-1,nullptr,nullptr));
 }
 
+const Size& Label::getContentSize()
+{
+    if (_contentDirty)
+    {
+        updateContent();
+    }
+    return Node::getContentSize();
+}
 NS_CC_END
diff --git a/cocos/2d/CCLabel.h b/cocos/2d/CCLabel.h
index e17b3644b9..a9239e3e9d 100644
--- a/cocos/2d/CCLabel.h
+++ b/cocos/2d/CCLabel.h
@@ -82,6 +82,13 @@ public:
 
     static Label* create();
 
+    /** creates a Label from a font name, horizontal alignment, dimension in points, and font size in points.
+     * @warning It will generate texture by the platform-dependent code if [fontName] not a font file.
+     */
+    static Label * create(const std::string& text, const std::string& fontName, float fontSize,
+        const Size& dimensions = Size::ZERO, TextHAlignment hAlignment = TextHAlignment::LEFT,
+        TextVAlignment vAlignment = TextVAlignment::TOP);
+
     CC_DEPRECATED_ATTRIBUTE static Label* createWithTTF(const std::string& label, const std::string& fontFilePath, 
         int fontSize, int lineSize = 0, TextHAlignment alignment = TextHAlignment::LEFT, 
         GlyphCollection glyphs = GlyphCollection::NEHE, const char *customGlyphs = 0, bool useDistanceField = false);
@@ -99,6 +106,12 @@ public:
     static Label * createWithCharMap(Texture2D* texture, int itemWidth, int itemHeight, int startCharMap);
     static Label * createWithCharMap(const std::string& plistFile);
 
+    /** create a lable with string and a font definition
+     * @warning It will generate texture by the platform-dependent code and create Sprite for show text.
+     * To obtain better performance use createWithTTF/createWithBMFont/createWithCharMap
+     */
+    static Label * createWithFontDefinition(const std::string& text, FontDefinition &textDefinition);
+
     /** set TTF configuration for Label */
     virtual bool setTTFConfig(const TTFConfig& ttfConfig);
 
@@ -108,14 +121,21 @@ public:
     virtual bool setCharMap(Texture2D* texture, int itemWidth, int itemHeight, int startCharMap);
     virtual bool setCharMap(const std::string& plistFile);
 
+    /** set the text definition used by this label
+     * It will create Sprite for show text if you haven't set up using TTF/BMFont/CharMap.
+     */
+    virtual void setFontDefinition(const FontDefinition& textDefinition);
+
+    /** get the text definition used by this label */
+    const FontDefinition& getFontDefinition() const { return _fontDefinition; }
+
     /** changes the string to render
-    * 
+    * @warning It is as expensive as changing the string if you havn¡¯t set up using TTF/BMFont/CharMap for label.
     */
     virtual void setString(const std::string& text) override;
 
     virtual const std::string& getString() const override {  return _originalUTF8String; }
 
-
     CC_DEPRECATED_ATTRIBUTE void setLabelEffect(LabelEffect effect,const Color3B& effectColor);
 
     /**
@@ -135,15 +155,15 @@ public:
     virtual void disableEffect();
     
 
-    virtual void setAlignment(TextHAlignment hAlignment,bool aligntext = true);
+    virtual void setAlignment(TextHAlignment hAlignment);
     TextHAlignment getTextAlignment() const { return _hAlignment;}
 
-    virtual void setAlignment(TextHAlignment hAlignment,TextVAlignment vAlignment,bool aligntext = true);
+    virtual void setAlignment(TextHAlignment hAlignment,TextVAlignment vAlignment);
 
-    virtual void setHorizontalAlignment(TextHAlignment alignment,bool aligntext = true);
+    virtual void setHorizontalAlignment(TextHAlignment alignment);
     TextHAlignment getHorizontalAlignment() const { return _hAlignment; }
 
-    virtual void setVerticalAlignment(TextVAlignment verticalAlignment,bool aligntext = true);
+    virtual void setVerticalAlignment(TextVAlignment verticalAlignment);
     TextVAlignment getVerticalAlignment() const { return _vAlignment; }
 
     virtual void setLineBreakWithoutSpace(bool breakWithoutSpace);
@@ -172,6 +192,15 @@ public:
     /** Sets the untransformed size of the label in a more efficient way. */
     virtual void setDimensions(unsigned int width,unsigned int height);
     
+    /** update content immediately.*/
+    virtual void updateContent();
+
+    virtual void setFontName(const std::string& fontName);
+    const std::string& getFontName() const;
+
+    virtual void setFontSize(int fontSize);
+    int getFontSize() const;
+
     virtual bool isOpacityModifyRGB() const override;
     virtual void setOpacityModifyRGB(bool isOpacityModifyRGB) override;
     virtual void setColor(const Color3B& color) override;
@@ -198,6 +227,8 @@ public:
     virtual void addChild(Node * child, int zOrder=0, int tag=0) override;
     virtual std::string getDescription() const override;
 
+    virtual const Size& getContentSize();
+
 protected:
     void onDraw(const kmMat4& transform, bool transformUpdated);
 
@@ -208,6 +239,14 @@ protected:
         Point position;
         Size  contentSize;
     };
+    enum class LabelType {
+
+        TypeTTF,
+        TypeBMFONT,
+        TypeCHARMAP,
+        TypeSPRITE
+    };
+
     /**
     * @js NA
     */
@@ -243,7 +282,11 @@ protected:
 
     void drawShadowWithoutBlur();
 
+    void createSpriteWithFontDefinition();
+
     bool _isOpacityModifyRGB;
+    bool _contentDirty;
+    LabelType _currLabelType;
 
     std::vector<SpriteBatchNode*> _batchNodes;
     FontAtlas *                   _fontAtlas;
@@ -251,6 +294,10 @@ protected:
 
     TTFConfig _fontConfig;
 
+    //compatibility with older LabelTTF
+    Sprite* _textSprite;
+    FontDefinition _fontDefinition;
+
     //! used for optimization
     Sprite *_reusedLetter;
     Rect _reusedRect;
diff --git a/samples/cpp-tests/Classes/LabelTest/LabelTestNew.cpp b/samples/cpp-tests/Classes/LabelTest/LabelTestNew.cpp
index f26ef223b9..a57c84cd36 100644
--- a/samples/cpp-tests/Classes/LabelTest/LabelTestNew.cpp
+++ b/samples/cpp-tests/Classes/LabelTest/LabelTestNew.cpp
@@ -76,6 +76,7 @@ static std::function<Layer*()> createFunctions[] =
     CL(LabelCharMapColorTest),
     CL(LabelCrashTest),
     CL(LabelTTFOldNew),
+    CL(LabelFontNameTest),
     CL(LabelAlignmentTest)
 };
 
@@ -1558,7 +1559,7 @@ void LabelTTFOldNew::onDraw(const kmMat4 &transform, bool transformUpdated)
     kmGLPushMatrix();
     kmGLLoadMatrix(&transform);
 
-    auto label1 = (Label*)getChildByTag(kTagBitmapAtlas1);
+    auto label1 = (LabelTTF*)getChildByTag(kTagBitmapAtlas1);
     auto labelSize = label1->getContentSize();
     auto origin    = Director::getInstance()->getWinSize();
     
@@ -1612,6 +1613,40 @@ std::string LabelTTFOldNew::subtitle() const
     return "Comparison between old(red) and new(white) TTF label";
 }
 
+LabelFontNameTest::LabelFontNameTest()
+{
+    auto size = Director::getInstance()->getWinSize();
+
+    auto label1 = Label::create();
+    label1->setString("Default Font");
+    label1->setPosition( Point(size.width/2, size.height * 0.7) );
+    label1->setAnchorPoint(Point::ANCHOR_MIDDLE);
+    addChild(label1);
+
+    FontDefinition fontDef;
+    fontDef._fontName = "Marker Felt";
+    fontDef._fontSize = 32;
+    auto label2 = Label::createWithFontDefinition("Create with FontDefinition",fontDef);
+    label2->setPosition( Point(size.width/2, size.height * 0.6) );
+    label2->setAnchorPoint(Point::ANCHOR_MIDDLE);
+    addChild(label2);
+
+    auto label3 = Label::create("Marker Felt","Marker Felt",32);
+    label3->setPosition( Point(size.width/2, size.height * 0.5) );
+    label3->setAnchorPoint(Point::ANCHOR_MIDDLE);
+    addChild(label3);
+}
+
+std::string LabelFontNameTest::title() const
+{
+    return "New Label Test";
+}
+
+std::string LabelFontNameTest::subtitle() const
+{
+    return "create label by font name,compatible with old labelTTF";
+}
+
 LabelAlignmentTest::LabelAlignmentTest()
 {
     auto blockSize = Size(200, 160);
@@ -1666,42 +1701,42 @@ LabelAlignmentTest::~LabelAlignmentTest()
 void LabelAlignmentTest::setAlignmentLeft(Ref* sender)
 {
     _horizAlign = TextHAlignment::LEFT;
-    _label->setHorizontalAlignment(_horizAlign,false);
+    _label->setHorizontalAlignment(_horizAlign);
     _label->setString(getCurrentAlignment());
 }
 
 void LabelAlignmentTest::setAlignmentCenter(Ref* sender)
 {
     _horizAlign = TextHAlignment::CENTER;
-    _label->setHorizontalAlignment(_horizAlign,false);
+    _label->setHorizontalAlignment(_horizAlign);
     _label->setString(getCurrentAlignment()); 
 }
 
 void LabelAlignmentTest::setAlignmentRight(Ref* sender)
 {
     _horizAlign = TextHAlignment::RIGHT;
-    _label->setHorizontalAlignment(_horizAlign,false);
+    _label->setHorizontalAlignment(_horizAlign);
     _label->setString(getCurrentAlignment());
 }
 
 void LabelAlignmentTest::setAlignmentTop(Ref* sender)
 {
     _vertAlign = TextVAlignment::TOP;
-    _label->setVerticalAlignment(_vertAlign,false);
+    _label->setVerticalAlignment(_vertAlign);
     _label->setString(getCurrentAlignment());
 }
 
 void LabelAlignmentTest::setAlignmentMiddle(Ref* sender)
 {
     _vertAlign = TextVAlignment::CENTER;
-    _label->setVerticalAlignment(_vertAlign,false);
+    _label->setVerticalAlignment(_vertAlign);
     _label->setString(getCurrentAlignment());
 }
 
 void LabelAlignmentTest::setAlignmentBottom(Ref* sender)
 {
     _vertAlign = TextVAlignment::BOTTOM;
-    _label->setVerticalAlignment(_vertAlign,false);
+    _label->setVerticalAlignment(_vertAlign);
     _label->setString(getCurrentAlignment());
 }
 
diff --git a/samples/cpp-tests/Classes/LabelTest/LabelTestNew.h b/samples/cpp-tests/Classes/LabelTest/LabelTestNew.h
index 4839d66897..697adfc48b 100644
--- a/samples/cpp-tests/Classes/LabelTest/LabelTestNew.h
+++ b/samples/cpp-tests/Classes/LabelTest/LabelTestNew.h
@@ -450,6 +450,17 @@ public:
     virtual std::string subtitle() const override;
 };
 
+class LabelFontNameTest : public AtlasDemoNew
+{
+public:
+    CREATE_FUNC(LabelFontNameTest);
+
+    LabelFontNameTest();
+
+    virtual std::string title() const override;
+    virtual std::string subtitle() const override;
+};
+
 class LabelAlignmentTest : public AtlasDemoNew
 {
 public:

From 11d3acd4780e9adb0ef6e05acecc3b18af083c65 Mon Sep 17 00:00:00 2001
From: Dhilan007 <wenhai.lin@chukong-inc.com>
Date: Mon, 10 Mar 2014 20:35:36 +0800
Subject: [PATCH 2/4] fixed inappropriate usage of inline.

---
 cocos/2d/CCLabel.cpp | 64 +++++++++-----------------------------------
 cocos/2d/CCLabel.h   | 26 +++++++++---------
 2 files changed, 25 insertions(+), 65 deletions(-)

diff --git a/cocos/2d/CCLabel.cpp b/cocos/2d/CCLabel.cpp
index 16623d7b2e..3592fa4ff3 100644
--- a/cocos/2d/CCLabel.cpp
+++ b/cocos/2d/CCLabel.cpp
@@ -212,7 +212,7 @@ bool Label::setCharMap(const std::string& plistFile)
 
     if (initWithFontAtlas(newAtlas))
     {
-        _currLabelType = LabelType::TypeCHARMAP;
+        _currentLabelType = LabelType::CHARMAP;
         return true;
     }
 
@@ -228,7 +228,7 @@ bool Label::setCharMap(Texture2D* texture, int itemWidth, int itemHeight, int st
 
     if (initWithFontAtlas(newAtlas))
     {
-        _currLabelType = LabelType::TypeCHARMAP;
+        _currentLabelType = LabelType::CHARMAP;
         return true;
     }
 
@@ -244,7 +244,7 @@ bool Label::setCharMap(const std::string& charMapFile, int itemWidth, int itemHe
 
     if (initWithFontAtlas(newAtlas))
     {
-        _currLabelType = LabelType::TypeCHARMAP;
+        _currentLabelType = LabelType::CHARMAP;
         return true;
     }
 
@@ -402,7 +402,7 @@ bool Label::setTTFConfig(const TTFConfig& ttfConfig)
         {
             this->setFontScale(1.0f * ttfConfig.fontSize / DefultFontSize);
         }
-        _currLabelType = LabelType::TypeTTF;
+        _currentLabelType = LabelType::TTF;
         return true;
     }
     else
@@ -420,41 +420,26 @@ bool Label::setBMFontFilePath(const std::string& bmfontFilePath, const Point& im
 
     if (initWithFontAtlas(newAtlas))
     {
-        _currLabelType = LabelType::TypeBMFONT;
+        _currentLabelType = LabelType::BMFONT;
         return true;
     }
 
     return false;
 }
 
-inline void Label::setFontDefinition(const FontDefinition& textDefinition)
+void Label::setFontDefinition(const FontDefinition& textDefinition)
 {
     _fontDefinition = textDefinition;
-    _currLabelType = LabelType::TypeSPRITE;
+    _currentLabelType = LabelType::STRING_TEXTURE;
     _contentDirty = true;
 }
 
-inline void Label::setString(const std::string& text)
+void Label::setString(const std::string& text)
 {
     _originalUTF8String = text;
     _contentDirty = true;
 }
 
-void Label::setAlignment(TextHAlignment hAlignment)
-{
-    setAlignment(hAlignment,_vAlignment);
-}
-
-inline void Label::setHorizontalAlignment(TextHAlignment hAlignment)
-{
-    setAlignment(hAlignment,_vAlignment);
-}
-
-inline void Label::setVerticalAlignment(TextVAlignment vAlignment)
-{
-    setAlignment(_hAlignment,vAlignment);
-}
-
 void Label::setAlignment(TextHAlignment hAlignment,TextVAlignment vAlignment)
 {
     if (hAlignment != _hAlignment || vAlignment != _vAlignment)
@@ -478,16 +463,6 @@ void Label::setMaxLineWidth(unsigned int maxLineWidth)
     }
 }
 
-inline void Label::setWidth(unsigned int width)
-{
-    setDimensions(width,_labelHeight);
-}
-
-inline void Label::setHeight(unsigned int height)
-{
-    setDimensions(_labelWidth,height);
-}
-
 void Label::setDimensions(unsigned int width,unsigned int height)
 {
     if (height != _labelHeight || width != _labelWidth)
@@ -795,7 +770,7 @@ void Label::enableOutline(const Color4B& outlineColor,int outlineSize /* = 1 */)
 
     if (outlineSize > 0)
     {
-        if (_currLabelType == LabelType::TypeTTF)
+        if (_currentLabelType == LabelType::TTF)
         {
             if (_fontConfig.outlineSize != outlineSize)
             { 
@@ -941,7 +916,7 @@ void Label::draw(Renderer *renderer, const kmMat4 &transform, bool transformUpda
 
 void Label::createSpriteWithFontDefinition()
 {
-    _currLabelType = LabelType::TypeSPRITE;
+    _currentLabelType = LabelType::STRING_TEXTURE;
     auto texture = new Texture2D;
 #if (CC_TARGET_PLATFORM != CC_PLATFORM_ANDROID) && (CC_TARGET_PLATFORM != CC_PLATFORM_IOS)
     if (_fontDefinition._shadow._shadowEnabled || _fontDefinition._stroke._strokeEnabled)
@@ -1039,14 +1014,9 @@ void Label::setFontName(const std::string& fontName)
     _contentDirty = true;
 }
 
-inline const std::string& Label::getFontName() const
-{
-    return _fontDefinition._fontName;
-}
-
 void Label::setFontSize(int fontSize)
 {
-    if (_currLabelType == LabelType::TypeTTF)
+    if (_currentLabelType == LabelType::TTF)
     {
         if (_fontConfig.distanceFieldEnabled == true)
         {
@@ -1068,10 +1038,6 @@ void Label::setFontSize(int fontSize)
     }
 }
 
-inline int Label::getFontSize() const
-{
-    return _fontDefinition._fontSize;
-}
 ///// PROTOCOL STUFF
 Sprite * Label::getLetter(int lettetIndex)
 {
@@ -1114,12 +1080,6 @@ int Label::getCommonLineHeight() const
     return _textSprite ? 0 : _commonLineHeight;
 }
 
-// string related stuff
-inline int Label::getStringNumLines() const
-{
-    return _currNumLines;
-}
-
 void Label::computeStringNumLines()
 {
     int quantityOfLines = 1;
@@ -1149,7 +1109,7 @@ int Label::getStringLength() const
 }
 
 // RGBA protocol
-inline bool Label::isOpacityModifyRGB() const
+bool Label::isOpacityModifyRGB() const
 {
     return _isOpacityModifyRGB;
 }
diff --git a/cocos/2d/CCLabel.h b/cocos/2d/CCLabel.h
index a9239e3e9d..519b03318a 100644
--- a/cocos/2d/CCLabel.h
+++ b/cocos/2d/CCLabel.h
@@ -155,15 +155,15 @@ public:
     virtual void disableEffect();
     
 
-    virtual void setAlignment(TextHAlignment hAlignment);
+    void setAlignment(TextHAlignment hAlignment) { setAlignment(hAlignment,_vAlignment);}
     TextHAlignment getTextAlignment() const { return _hAlignment;}
 
     virtual void setAlignment(TextHAlignment hAlignment,TextVAlignment vAlignment);
 
-    virtual void setHorizontalAlignment(TextHAlignment alignment);
+    void setHorizontalAlignment(TextHAlignment hAlignment) { setAlignment(hAlignment,_vAlignment); }
     TextHAlignment getHorizontalAlignment() const { return _hAlignment; }
 
-    virtual void setVerticalAlignment(TextVAlignment verticalAlignment);
+    void setVerticalAlignment(TextVAlignment vAlignment) { setAlignment(_hAlignment,vAlignment); }
     TextVAlignment getVerticalAlignment() const { return _vAlignment; }
 
     virtual void setLineBreakWithoutSpace(bool breakWithoutSpace);
@@ -179,14 +179,14 @@ public:
      * The label's width be used for text align if the set value not equal zero.
      * The label's max line width will be equal to the same value.
      */
-    virtual void setWidth(unsigned int width);
+    void setWidth(unsigned int width) { setDimensions(width,_labelHeight);}
     unsigned int getWidth() const { return _labelWidth; }  
 
     /** Sets the untransformed size of the label.
      * The label's height be used for text align if the set value not equal zero.
      * The text will display of incomplete when the size of label not enough to support display all text.
      */
-    virtual void setHeight(unsigned int height);
+    void setHeight(unsigned int height){ setDimensions(_labelWidth,height);}
     unsigned int getHeight() const { return _labelHeight;}   
 
     /** Sets the untransformed size of the label in a more efficient way. */
@@ -196,10 +196,10 @@ public:
     virtual void updateContent();
 
     virtual void setFontName(const std::string& fontName);
-    const std::string& getFontName() const;
+    const std::string& getFontName() const { return _fontDefinition._fontName;}
 
     virtual void setFontSize(int fontSize);
-    int getFontSize() const;
+    int getFontSize() const { return _fontDefinition._fontSize;}
 
     virtual bool isOpacityModifyRGB() const override;
     virtual void setOpacityModifyRGB(bool isOpacityModifyRGB) override;
@@ -211,7 +211,7 @@ public:
     int getCommonLineHeight() const;
     
     // string related stuff
-    int getStringNumLines() const;
+    int getStringNumLines() const { return _currNumLines;}
     CC_DEPRECATED_ATTRIBUTE int getStringLenght() const { return getStringLength(); }
     int getStringLength() const;
     
@@ -241,10 +241,10 @@ protected:
     };
     enum class LabelType {
 
-        TypeTTF,
-        TypeBMFONT,
-        TypeCHARMAP,
-        TypeSPRITE
+        TTF,
+        BMFONT,
+        CHARMAP,
+        STRING_TEXTURE
     };
 
     /**
@@ -286,7 +286,7 @@ protected:
 
     bool _isOpacityModifyRGB;
     bool _contentDirty;
-    LabelType _currLabelType;
+    LabelType _currentLabelType;
 
     std::vector<SpriteBatchNode*> _batchNodes;
     FontAtlas *                   _fontAtlas;

From 792e182e122f14c57687902441cfe94cf589a272 Mon Sep 17 00:00:00 2001
From: Dhilan007 <wenhai.lin@chukong-inc.com>
Date: Tue, 11 Mar 2014 14:32:07 +0800
Subject: [PATCH 3/4] typo fix and coding style improvements.

---
 cocos/2d/CCLabel.cpp | 48 ++++++++++++--------------------------------
 cocos/2d/CCLabel.h   | 23 +++++++++++----------
 2 files changed, 25 insertions(+), 46 deletions(-)

diff --git a/cocos/2d/CCLabel.cpp b/cocos/2d/CCLabel.cpp
index 3592fa4ff3..4c8c11d625 100644
--- a/cocos/2d/CCLabel.cpp
+++ b/cocos/2d/CCLabel.cpp
@@ -50,7 +50,7 @@ Label* Label::create()
     return ret;
 }
 
-Label* Label::createWithFontDefinition(const std::string& text, FontDefinition &textDefinition)
+Label* Label::createWithFontDefinition(const std::string& text, const FontDefinition &textDefinition)
 {
     auto ret = new Label();
 
@@ -258,6 +258,7 @@ Label::Label(FontAtlas *atlas, TextHAlignment alignment, bool useDistanceField,b
 , _maxLineWidth(0)
 , _labelWidth(0)
 , _labelHeight(0)
+, _labelDimensions(Size::ZERO)
 , _hAlignment(alignment)
 , _currentUTF16String(nullptr)
 , _originalUTF16String(nullptr)
@@ -456,7 +457,7 @@ void Label::setAlignment(TextHAlignment hAlignment,TextVAlignment vAlignment)
 
 void Label::setMaxLineWidth(unsigned int maxLineWidth)
 {
-    if (_maxLineWidth != maxLineWidth)
+    if (_labelWidth == 0 && _maxLineWidth != maxLineWidth)
     {
         _maxLineWidth = maxLineWidth;
         _contentDirty = true;
@@ -470,8 +471,11 @@ void Label::setDimensions(unsigned int width,unsigned int height)
         _fontDefinition._dimensions.width = width;
         _fontDefinition._dimensions.height = height;
 
-        _labelHeight = height;
         _labelWidth = width;
+        _labelHeight = height;
+        _labelDimensions.width = width;
+        _labelDimensions.height = height;
+
         _maxLineWidth = width;
         _contentDirty = true;
     }  
@@ -481,15 +485,8 @@ void Label::setLineBreakWithoutSpace(bool breakWithoutSpace)
 {
     if (breakWithoutSpace != _lineBreakWithoutSpaces)
     {
-        // store
         _lineBreakWithoutSpaces = breakWithoutSpace;
-
-        // need to align text again
-        if(_currentUTF16String)
-        {
-            resetCurrentString();
-            alignText();
-        }
+        _contentDirty = true;     
     }
 }
 
@@ -572,7 +569,7 @@ void Label::alignText()
     if(_maxLineWidth > 0 && _contentSize.width > _maxLineWidth && LabelTextFormatter::multilineText(this) )      
         LabelTextFormatter::createStringSprites(this);
 
-    if(_labelWidth >0 || (_currNumLines > 1 && _hAlignment != TextHAlignment::LEFT))
+    if(_labelWidth > 0 || (_currNumLines > 1 && _hAlignment != TextHAlignment::LEFT))
         LabelTextFormatter::alignText(this);
 
     int strLen = cc_wcslen(_currentUTF16String);
@@ -667,25 +664,6 @@ bool Label::setCurrentString(unsigned short *stringToSet)
     return true;
 }
 
-void Label::resetCurrentString()
-{
-    if ((!_currentUTF16String) && (!_originalUTF16String))
-        return;
-
-    // set the new string
-    if (_currentUTF16String)
-    {
-        delete [] _currentUTF16String;
-        _currentUTF16String = 0;
-    }
-
-    int stringLenght = cc_wcslen(_originalUTF16String);
-    _currentUTF16String = new unsigned short int [stringLenght + 1];
-    memcpy(_currentUTF16String, _originalUTF16String, stringLenght * 2);
-    _currentUTF16String[stringLenght] = 0;
-
-}
-
 void Label::updateSpriteWithLetterDefinition(const FontLetterDefinition &theDefinition, Texture2D *theTexture)
 {
     _reusedRect.size.height = theDefinition.height;
@@ -757,7 +735,7 @@ void Label::setLabelEffect(LabelEffect effect,const Color3B& effectColor)
 
 void Label::enableGlow(const Color3B& glowColor)
 {
-    if(_useDistanceField == false)
+    if(! _useDistanceField)
         return;
     _currLabelEffect = LabelEffect::GLOW;
     _effectColor = glowColor;
@@ -943,7 +921,7 @@ void Label::updateContent()
     setOriginalString(utf16String);
     if (_textSprite)
     {
-        _textSprite->removeFromParent();
+        Node::removeChild(_textSprite,true);
         _textSprite = nullptr;
     }
     if (_fontAtlas)
@@ -1018,7 +996,7 @@ void Label::setFontSize(int fontSize)
 {
     if (_currentLabelType == LabelType::TTF)
     {
-        if (_fontConfig.distanceFieldEnabled == true)
+        if (_fontConfig.distanceFieldEnabled)
         {
             _fontConfig.fontSize = fontSize;
             this->setFontScale(1.0f * fontSize / DefultFontSize);
@@ -1048,7 +1026,7 @@ Sprite * Label::getLetter(int lettetIndex)
     
     if (! _textSprite && lettetIndex < _limitShowCount)
     {
-        if(_lettersInfo[lettetIndex].def.validDefinition == false)
+        if(! _lettersInfo[lettetIndex].def.validDefinition)
             return nullptr;
 
         Sprite* sp = static_cast<Sprite*>(this->getChildByTag(lettetIndex));
diff --git a/cocos/2d/CCLabel.h b/cocos/2d/CCLabel.h
index 519b03318a..e22a07a0e3 100644
--- a/cocos/2d/CCLabel.h
+++ b/cocos/2d/CCLabel.h
@@ -110,7 +110,7 @@ public:
      * @warning It will generate texture by the platform-dependent code and create Sprite for show text.
      * To obtain better performance use createWithTTF/createWithBMFont/createWithCharMap
      */
-    static Label * createWithFontDefinition(const std::string& text, FontDefinition &textDefinition);
+    static Label * createWithFontDefinition(const std::string& text, const FontDefinition &textDefinition);
 
     /** set TTF configuration for Label */
     virtual bool setTTFConfig(const TTFConfig& ttfConfig);
@@ -130,7 +130,7 @@ public:
     const FontDefinition& getFontDefinition() const { return _fontDefinition; }
 
     /** changes the string to render
-    * @warning It is as expensive as changing the string if you havn¡¯t set up using TTF/BMFont/CharMap for label.
+    * @warning It is as expensive as changing the string if you haven't set up TTF/BMFont/CharMap for the label.
     */
     virtual void setString(const std::string& text) override;
 
@@ -158,7 +158,7 @@ public:
     void setAlignment(TextHAlignment hAlignment) { setAlignment(hAlignment,_vAlignment);}
     TextHAlignment getTextAlignment() const { return _hAlignment;}
 
-    virtual void setAlignment(TextHAlignment hAlignment,TextVAlignment vAlignment);
+    void setAlignment(TextHAlignment hAlignment,TextVAlignment vAlignment);
 
     void setHorizontalAlignment(TextHAlignment hAlignment) { setAlignment(hAlignment,_vAlignment); }
     TextHAlignment getHorizontalAlignment() const { return _hAlignment; }
@@ -166,13 +166,13 @@ public:
     void setVerticalAlignment(TextVAlignment vAlignment) { setAlignment(_hAlignment,vAlignment); }
     TextVAlignment getVerticalAlignment() const { return _vAlignment; }
 
-    virtual void setLineBreakWithoutSpace(bool breakWithoutSpace);
+    void setLineBreakWithoutSpace(bool breakWithoutSpace);
 
     /** Sets the max line width of the label.
      * The label's max line width be used for force line breaks if the set value not equal zero.
      * The label's width and max line width has not always to be equal.
      */
-    virtual void setMaxLineWidth(unsigned int maxLineWidth);
+    void setMaxLineWidth(unsigned int maxLineWidth);
     unsigned int getMaxLineWidth() { return _maxLineWidth;}
 
     /** Sets the untransformed size of the label.
@@ -190,16 +190,17 @@ public:
     unsigned int getHeight() const { return _labelHeight;}   
 
     /** Sets the untransformed size of the label in a more efficient way. */
-    virtual void setDimensions(unsigned int width,unsigned int height);
-    
+    void setDimensions(unsigned int width,unsigned int height);
+    const Size& getDimensions() const{ return _labelDimensions;}
+
     /** update content immediately.*/
     virtual void updateContent();
 
     virtual void setFontName(const std::string& fontName);
-    const std::string& getFontName() const { return _fontDefinition._fontName;}
+    virtual const std::string& getFontName() const { return _fontDefinition._fontName;}
 
     virtual void setFontSize(int fontSize);
-    int getFontSize() const { return _fontDefinition._fontSize;}
+    virtual int getFontSize() const { return _fontDefinition._fontSize;}
 
     virtual bool isOpacityModifyRGB() const override;
     virtual void setOpacityModifyRGB(bool isOpacityModifyRGB) override;
@@ -212,8 +213,8 @@ public:
     
     // string related stuff
     int getStringNumLines() const { return _currNumLines;}
-    CC_DEPRECATED_ATTRIBUTE int getStringLenght() const { return getStringLength(); }
     int getStringLength() const;
+    CC_DEPRECATED_ATTRIBUTE int getStringLenght() const { return getStringLength(); }
     
     virtual void visit(Renderer *renderer, const kmMat4 &parentTransform, bool parentTransformUpdated) override;
     virtual void draw(Renderer *renderer, const kmMat4 &transform, bool transformUpdated) override;
@@ -271,7 +272,6 @@ protected:
     bool computeHorizontalKernings(unsigned short int *stringToRender);
     bool setCurrentString(unsigned short *stringToSet);
     bool setOriginalString(unsigned short *stringToSet);
-    void resetCurrentString();
     void computeStringNumLines();
 
     void updateSpriteWithLetterDefinition(const FontLetterDefinition &theDefinition, Texture2D *theTexture);
@@ -308,6 +308,7 @@ protected:
     int * _horizontalKernings;
 
     unsigned int _maxLineWidth;
+    Size         _labelDimensions;
     unsigned int _labelWidth;
     unsigned int _labelHeight;
     TextHAlignment _hAlignment;

From c2ef7b87961a47f84989e97b127894e721731cf6 Mon Sep 17 00:00:00 2001
From: Dhilan007 <wenhai.lin@chukong-inc.com>
Date: Tue, 11 Mar 2014 15:03:16 +0800
Subject: [PATCH 4/4] fix incorrect implementation of Label::getContentSize

---
 cocos/2d/CCLabel.cpp | 4 ++--
 cocos/2d/CCLabel.h   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/cocos/2d/CCLabel.cpp b/cocos/2d/CCLabel.cpp
index 4c8c11d625..eda91b92f8 100644
--- a/cocos/2d/CCLabel.cpp
+++ b/cocos/2d/CCLabel.cpp
@@ -1155,11 +1155,11 @@ std::string Label::getDescription() const
     return StringUtils::format("<Label | Tag = %d, Label = '%s'>", _tag, cc_utf16_to_utf8(_currentUTF16String,-1,nullptr,nullptr));
 }
 
-const Size& Label::getContentSize()
+const Size& Label::getContentSize() const
 {
     if (_contentDirty)
     {
-        updateContent();
+        const_cast<Label*>(this)->updateContent();
     }
     return Node::getContentSize();
 }
diff --git a/cocos/2d/CCLabel.h b/cocos/2d/CCLabel.h
index e22a07a0e3..b362f9ef5c 100644
--- a/cocos/2d/CCLabel.h
+++ b/cocos/2d/CCLabel.h
@@ -228,7 +228,7 @@ public:
     virtual void addChild(Node * child, int zOrder=0, int tag=0) override;
     virtual std::string getDescription() const override;
 
-    virtual const Size& getContentSize();
+    virtual const Size& getContentSize() const override;
 
 protected:
     void onDraw(const kmMat4& transform, bool transformUpdated);