From e20c347767de137577e3dee32842f3337a4a5177 Mon Sep 17 00:00:00 2001 From: raydelto Date: Wed, 31 Dec 2014 20:51:45 -0400 Subject: [PATCH 1/4] Fixing typo in the constant INVAILD_AUDIO_ID of the new AudioEngine, changing it to INVALID_AUDIO_ID --- cocos/audio/AudioEngine.cpp | 6 ++-- cocos/audio/android/AudioEngine-inl.cpp | 2 +- cocos/audio/apple/AudioEngine-inl.mm | 4 +-- cocos/audio/include/AudioEngine.h | 2 +- cocos/audio/win32/AudioEngine-win32.cpp | 4 +-- .../NewAudioEngineTest/NewAudioEngineTest.cpp | 30 +++++++++---------- 6 files changed, 24 insertions(+), 24 deletions(-) diff --git a/cocos/audio/AudioEngine.cpp b/cocos/audio/AudioEngine.cpp index 0c5b93c2a2..cbfc5ed08b 100644 --- a/cocos/audio/AudioEngine.cpp +++ b/cocos/audio/AudioEngine.cpp @@ -47,7 +47,7 @@ using namespace cocos2d; using namespace cocos2d::experimental; -const int AudioEngine::INVAILD_AUDIO_ID = -1; +const int AudioEngine::INVALID_AUDIO_ID = -1; const float AudioEngine::TIME_UNKNOWN = -1.0f; //audio file path,audio IDs @@ -85,7 +85,7 @@ bool AudioEngine::lazyInit() int AudioEngine::play2d(const std::string& filePath, bool loop, float volume, const AudioProfile *profile) { - int ret = AudioEngine::INVAILD_AUDIO_ID; + int ret = AudioEngine::INVALID_AUDIO_ID; do { if ( !lazyInit() ){ @@ -130,7 +130,7 @@ int AudioEngine::play2d(const std::string& filePath, bool loop, float volume, co } ret = _audioEngineImpl->play2d(filePath, loop, volume); - if (ret != INVAILD_AUDIO_ID) + if (ret != INVALID_AUDIO_ID) { _audioPathIDMap[filePath].push_back(ret); auto it = _audioPathIDMap.find(filePath); diff --git a/cocos/audio/android/AudioEngine-inl.cpp b/cocos/audio/android/AudioEngine-inl.cpp index 7860aedc18..a84fa071e7 100644 --- a/cocos/audio/android/AudioEngine-inl.cpp +++ b/cocos/audio/android/AudioEngine-inl.cpp @@ -229,7 +229,7 @@ bool AudioEngineImpl::init() int AudioEngineImpl::play2d(const std::string &filePath ,bool loop ,float volume) { - auto audioId = AudioEngine::INVAILD_AUDIO_ID; + auto audioId = AudioEngine::INVALID_AUDIO_ID; do { diff --git a/cocos/audio/apple/AudioEngine-inl.mm b/cocos/audio/apple/AudioEngine-inl.mm index e6a90d8f68..900ac702ea 100644 --- a/cocos/audio/apple/AudioEngine-inl.mm +++ b/cocos/audio/apple/AudioEngine-inl.mm @@ -187,7 +187,7 @@ bool AudioEngineImpl::init() int AudioEngineImpl::play2d(const std::string &filePath ,bool loop ,float volume) { if (s_ALDevice == nullptr) { - return AudioEngine::INVAILD_AUDIO_ID; + return AudioEngine::INVALID_AUDIO_ID; } bool sourceFlag = false; @@ -201,7 +201,7 @@ int AudioEngineImpl::play2d(const std::string &filePath ,bool loop ,float volume } } if(!sourceFlag){ - return AudioEngine::INVAILD_AUDIO_ID; + return AudioEngine::INVALID_AUDIO_ID; } AudioCache* audioCache = nullptr; diff --git a/cocos/audio/include/AudioEngine.h b/cocos/audio/include/AudioEngine.h index 51e7540347..721c3287a8 100644 --- a/cocos/audio/include/AudioEngine.h +++ b/cocos/audio/include/AudioEngine.h @@ -81,7 +81,7 @@ public: PAUSED }; - static const int INVAILD_AUDIO_ID; + static const int INVALID_AUDIO_ID; static const float TIME_UNKNOWN; diff --git a/cocos/audio/win32/AudioEngine-win32.cpp b/cocos/audio/win32/AudioEngine-win32.cpp index 44757db2cd..f131f7ed2c 100644 --- a/cocos/audio/win32/AudioEngine-win32.cpp +++ b/cocos/audio/win32/AudioEngine-win32.cpp @@ -205,7 +205,7 @@ int AudioEngineImpl::play2d(const std::string &filePath ,bool loop ,float volume } } if(!availableSourceExist){ - return AudioEngine::INVAILD_AUDIO_ID; + return AudioEngine::INVALID_AUDIO_ID; } AudioCache* audioCache = nullptr; @@ -244,7 +244,7 @@ int AudioEngineImpl::play2d(const std::string &filePath ,bool loop ,float volume if (eraseCache){ _audioCaches.erase(filePath); - return AudioEngine::INVAILD_AUDIO_ID; + return AudioEngine::INVALID_AUDIO_ID; } audioCache->_fileFullPath = FileUtils::getInstance()->fullPathForFilename(filePath); diff --git a/tests/cpp-tests/Classes/NewAudioEngineTest/NewAudioEngineTest.cpp b/tests/cpp-tests/Classes/NewAudioEngineTest/NewAudioEngineTest.cpp index d80eb27eb0..fb7ba66912 100644 --- a/tests/cpp-tests/Classes/NewAudioEngineTest/NewAudioEngineTest.cpp +++ b/tests/cpp-tests/Classes/NewAudioEngineTest/NewAudioEngineTest.cpp @@ -347,7 +347,7 @@ std::string AudioEngineTestDemo::title() const bool AudioControlTest::init() { auto ret = AudioEngineTestDemo::init(); - _audioID = AudioEngine::INVAILD_AUDIO_ID; + _audioID = AudioEngine::INVALID_AUDIO_ID; _loopEnabled = false; _volume = 1.0f; _duration = AudioEngine::TIME_UNKNOWN; @@ -359,13 +359,13 @@ bool AudioControlTest::init() auto& layerSize = this->getContentSize(); auto playItem = TextButton::create("play", [&](TextButton* button){ - if (_audioID == AudioEngine::INVAILD_AUDIO_ID) { + if (_audioID == AudioEngine::INVALID_AUDIO_ID) { _audioID = AudioEngine::play2d("background.mp3", _loopEnabled, _volume); - if(_audioID != AudioEngine::INVAILD_AUDIO_ID) { + if(_audioID != AudioEngine::INVALID_AUDIO_ID) { button->setEnabled(false); AudioEngine::setFinishCallback(_audioID, [&](int id, const std::string& filePath){ - _audioID = AudioEngine::INVAILD_AUDIO_ID; + _audioID = AudioEngine::INVALID_AUDIO_ID; ((TextButton*)_playItem)->setEnabled(true); _timeRatio = 0.0f; @@ -379,10 +379,10 @@ bool AudioControlTest::init() addChild(playItem); auto stopItem = TextButton::create("stop", [&](TextButton* button){ - if (_audioID != AudioEngine::INVAILD_AUDIO_ID ) { + if (_audioID != AudioEngine::INVALID_AUDIO_ID ) { AudioEngine::stop(_audioID); - _audioID = AudioEngine::INVAILD_AUDIO_ID; + _audioID = AudioEngine::INVALID_AUDIO_ID; ((TextButton*)_playItem)->setEnabled(true); } }); @@ -390,7 +390,7 @@ bool AudioControlTest::init() addChild(stopItem); auto pauseItem = TextButton::create("pause", [&](TextButton* button){ - if (_audioID != AudioEngine::INVAILD_AUDIO_ID ) { + if (_audioID != AudioEngine::INVALID_AUDIO_ID ) { AudioEngine::pause(_audioID); } }); @@ -398,7 +398,7 @@ bool AudioControlTest::init() addChild(pauseItem); auto resumeItem = TextButton::create("resume", [&](TextButton* button){ - if (_audioID != AudioEngine::INVAILD_AUDIO_ID ) { + if (_audioID != AudioEngine::INVALID_AUDIO_ID ) { AudioEngine::resume(_audioID); } }); @@ -408,7 +408,7 @@ bool AudioControlTest::init() auto loopItem = TextButton::create("enable-loop", [&](TextButton* button){ _loopEnabled = !_loopEnabled; - if (_audioID != AudioEngine::INVAILD_AUDIO_ID ) { + if (_audioID != AudioEngine::INVALID_AUDIO_ID ) { AudioEngine::setLoop(_audioID, _loopEnabled); } if(_loopEnabled){ @@ -424,7 +424,7 @@ bool AudioControlTest::init() auto uncacheItem = TextButton::create("uncache", [&](TextButton* button){ AudioEngine::uncache("background.mp3"); - _audioID = AudioEngine::INVAILD_AUDIO_ID; + _audioID = AudioEngine::INVALID_AUDIO_ID; ((TextButton*)_playItem)->setEnabled(true); }); uncacheItem->setPosition(layerSize.width * 0.7f,layerSize.height * 0.5f); @@ -434,7 +434,7 @@ bool AudioControlTest::init() volumeSlider->setPercent(100); volumeSlider->setCallBack([&](SliderEx* sender,float ratio,SliderEx::TouchEvent event){ _volume = ratio; - if (_audioID != AudioEngine::INVAILD_AUDIO_ID ) { + if (_audioID != AudioEngine::INVALID_AUDIO_ID ) { AudioEngine::setVolume(_audioID, _volume); } }); @@ -449,7 +449,7 @@ bool AudioControlTest::init() _updateTimeSlider = false; break; case SliderEx::TouchEvent::UP: - if (_audioID != AudioEngine::INVAILD_AUDIO_ID && _duration != AudioEngine::TIME_UNKNOWN) { + if (_audioID != AudioEngine::INVALID_AUDIO_ID && _duration != AudioEngine::TIME_UNKNOWN) { AudioEngine::setCurrentTime(_audioID,_duration * ratio); } case SliderEx::TouchEvent::CANCEL: @@ -481,7 +481,7 @@ bool AudioControlTest::init() void AudioControlTest::update(float dt) { - if (_audioID != AudioEngine::INVAILD_AUDIO_ID ) { + if (_audioID != AudioEngine::INVALID_AUDIO_ID ) { if(_duration == AudioEngine::TIME_UNKNOWN){ _duration = AudioEngine::getDuration(_audioID); } @@ -524,7 +524,7 @@ bool PlaySimultaneouslyTest::init() auto startTime = utils::gettime(); for(int index = 0; index < TEST_COUNT; ++index){ audioId = AudioEngine::play2d(_files[index]); - if(audioId != AudioEngine::INVAILD_AUDIO_ID){ + if(audioId != AudioEngine::INVALID_AUDIO_ID){ _playingcount += 1; AudioEngine::setFinishCallback(audioId, [&](int id, const std::string& filePath){ @@ -584,7 +584,7 @@ bool AudioProfileTest::init() auto playItem = TextButton::create(text, [&](TextButton* button){ int index = button->getTag(); auto id = AudioEngine::play2d(_files[index], false, 1.0f, &_audioProfile); - if(id != AudioEngine::INVAILD_AUDIO_ID){ + if(id != AudioEngine::INVALID_AUDIO_ID){ _time = _minDelay; _audioCount += 1; char show[30]; From 79e3e8463d8ce16a62540b6585a178624b5a6bde Mon Sep 17 00:00:00 2001 From: huangshiwu Date: Sun, 4 Jan 2015 10:54:29 +0800 Subject: [PATCH 2/4] fix iOS HttpClient immediately mode's bug --- cocos/network/HttpClient-ios.mm | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/cocos/network/HttpClient-ios.mm b/cocos/network/HttpClient-ios.mm index ea56d4af16..38da98b1ca 100644 --- a/cocos/network/HttpClient-ios.mm +++ b/cocos/network/HttpClient-ios.mm @@ -43,8 +43,6 @@ NS_CC_BEGIN -#define ERROR_SIZE 256 - namespace network { static std::mutex s_requestQueueMutex; @@ -55,10 +53,11 @@ static std::condition_variable_any s_SleepCondition; static Vector* s_requestQueue = nullptr; static Vector* s_responseQueue = nullptr; -static HttpClient *s_pHttpClient = nullptr; // pointer to singleton +static HttpClient *s_HttpClient = nullptr; // pointer to singleton -static HttpAsynConnection *httpAsynConn = nullptr; static HttpCookie *s_cookie = nullptr; + +static const int ERROR_SIZE = 256; static char s_errorBuffer[ERROR_SIZE] = {0}; @@ -106,7 +105,7 @@ void HttpClient::networkThread() s_responseQueue->pushBack(response); s_responseQueueMutex.unlock(); - if (nullptr != s_pHttpClient) { + if (nullptr != s_HttpClient) { scheduler->performFunctionInCocosThread(CC_CALLBACK_0(HttpClient::dispatchResponseCallbacks, this)); } } @@ -142,11 +141,11 @@ void HttpClient::networkThreadAlone(HttpRequest* request) if (callback != nullptr) { - callback(s_pHttpClient, response); + callback(s_HttpClient, response); } else if (pTarget && pSelector) { - (pTarget->*pSelector)(s_pHttpClient, response); + (pTarget->*pSelector)(s_HttpClient, response); } response->release(); // do not release in other thread @@ -218,7 +217,7 @@ static int processTask(HttpRequest *request, NSString* requestType, void *stream } } - httpAsynConn = [HttpAsynConnection new]; + HttpAsynConnection *httpAsynConn = [HttpAsynConnection new]; httpAsynConn.srcURL = urlstring; httpAsynConn.sslFile = nil; NSString *sslFile = nil; @@ -356,16 +355,16 @@ static void processResponse(HttpResponse* response, char* errorBuffer) // HttpClient implementation HttpClient* HttpClient::getInstance() { - if (s_pHttpClient == nullptr) { - s_pHttpClient = new (std::nothrow) HttpClient(); + if (s_HttpClient == nullptr) { + s_HttpClient = new (std::nothrow) HttpClient(); } - return s_pHttpClient; + return s_HttpClient; } void HttpClient::destroyInstance() { - CC_SAFE_DELETE(s_pHttpClient); + CC_SAFE_DELETE(s_HttpClient); } void HttpClient::enableCookies(const char* cookieFile) { @@ -403,7 +402,7 @@ HttpClient::~HttpClient() s_SleepCondition.notify_one(); } - s_pHttpClient = nullptr; + s_HttpClient = nullptr; if(!s_cookieFilename.empty()) { From 713de37c5bc187166a47eb5acb1667b90b8ae367 Mon Sep 17 00:00:00 2001 From: samuele3hu Date: Sun, 4 Jan 2015 13:49:41 +0800 Subject: [PATCH 3/4] Fix compile iOS compile error on the Xcode 5.1.1 --- cocos/network/HttpClient-ios.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cocos/network/HttpClient-ios.mm b/cocos/network/HttpClient-ios.mm index ea56d4af16..6312a837b0 100644 --- a/cocos/network/HttpClient-ios.mm +++ b/cocos/network/HttpClient-ios.mm @@ -256,7 +256,7 @@ static int processTask(HttpRequest *request, NSString* requestType, void *stream NSString *domain = cookie.domain; //BOOL session = cookie.sessionOnly; NSString *path = cookie.path; - BOOL secure = cookie.secure; + BOOL secure = cookie.isSecure; NSDate *date = cookie.expiresDate; NSString *name = cookie.name; NSString *value = cookie.value; From c9a2860ce26f221866623a5c417e64ef501d9240 Mon Sep 17 00:00:00 2001 From: minggo Date: Sun, 4 Jan 2015 14:51:00 +0800 Subject: [PATCH 4/4] [ci skip] Update CHANGELOG --- CHANGELOG | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG b/CHANGELOG index 7388b04c32..f28200d058 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,4 +1,5 @@ cocos2d-x-3.4rc0 Jan.9 2015 + [FIX] HttpClient: http requests will be lost in immediately mode on iOS [FIX] WP8: compiling error on ARM architecture cocos2d-x-3.4beta0 Dec.31 2014