Lothario
/
axmol
mirror of https://github.com/axmolengine/axmol.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10036 from samuele3hu/v3_4_rc1 

Update the luaval_to_int32 conversional function to get correct value
This commit is contained in:
minggo 2015-01-16 10:41:46 +08:00
parent 53cfd8229b 4601331dee
commit 9db2e54dc3
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
cocos/scripting/lua-bindings/manual/LuaBasicConversions.cpp
View File

@ -121,7 +121,22 @@ bool luaval_to_int32(lua_State* L,int lo,int* outValue, const char* funcName)
if (ok)
{
*outValue = (int)(unsigned int)lua_tonumber(L, lo);
/**
When we want to convert the number value from the Lua to int, we would call lua_tonumber to implement.It would
experience two phase conversion: int -> double, double->int.But,for the 0x80000000 which the min value of int, the
int cast may return an undefined result,like 0x7fffffff.So we must use the (int)(unsigned int)lua_tonumber() to get
predictable results for 0x80000000.In this place,we didn't use lua_tointeger, because it may produce differen results
depending on the compiler,e.g:for iPhone4s,it also get wrong value for 0x80000000.
*/
unsigned int estimateValue = (unsigned int)lua_tonumber(L, lo);
if (estimateValue == std::numeric_limits<int>::min())
{
*outValue = (int)estimateValue;
}
else
{
*outValue = (int)lua_tonumber(L, lo);
}
}
return ok;