Lothario
/
axmol
mirror of https://github.com/axmolengine/axmol.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix failed assertion and memory leak with event listeners (#1837) 

* Fix failed assertion and memory leak with event listeners

This solves an issue that was fixed for Cocos2d-x v3.16 and then reverted afterwards for "backwards compatibility".

I don't think we need this backwards compatibility anymore, and the benefits to cleaning up this memory outweigh the potential for some developers to need to refactor their code.

Specifically this also solves an ASSERT that fails when quitting the game on a scene which has nodes with Event Listeners that I experienced without this change, and with the Config.h setting AX_NODE_DEBUG_VERIFY_EVENT_LISTENERS enabled.

* Fixed typo
This commit is contained in:
Tyelor D. Klein 2024-04-18 18:42:43 -07:00 committed by GitHub
parent 547b5c0b38
commit d9a95c6a8d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
core/2d/Node.cpp
View File

@ -224,15 +224,14 @@ void Node::cleanup()
// timers
this->unscheduleAllCallbacks();
// NOTE: Although it was correct that removing event listeners associated with current node in Node::cleanup.
// But it broke the compatibility to the versions before v3.16 .
// User code may call `node->removeFromParent(true)` which will trigger node's cleanup method, when the node
// is added to scene again, event listeners like EventListenerTouchOneByOne will be lost.
// In fact, user's code should use `node->removeFromParent(false)` in order not to do a cleanup and just remove node
// from its parent. For more discussion about why we revert this change is at
// https://github.com/cocos2d/cocos2d-x/issues/18104. We need to consider more before we want to correct the old and
// wrong logic code. For now, compatiblity is the most important for our users.
// _eventDispatcher->removeEventListenersForTarget(this);
// This will stop Axmol from leaking event listeners on any objects that create them:
//
// Note: If you're moving a Node from one parent to another then you must remember to always call either removeChild(),
// or removeFromParentAndCleanup() with a cleanup bool parameter of false. Otherwise Nodes with listeners (e.g. buttons)
// will stop working when it's removed from it's parent and then added as a child to any Node.
//
// For more details read: https://discuss.cocos2d-x.org/t/note-compatibility-issue-of-node-cleanup-in-cocos2d-x-v3-16
_eventDispatcher->removeEventListenersForTarget(this);
for (const auto& child : _children)
child->cleanup();