Commit Graph

18393 Commits

Author SHA1 Message Date
James Chen d93a7e6445 Merge pull request #6177 from DarraghCoy/small_dangling_ptr_fix
Small dangling ptr fix to EventDispatcher::removeEventListenersForTarget
2014-04-09 13:22:24 +08:00
James Chen 5fae622209 Merge pull request #6181 from shujunqiao/console-std
modify const char* to std::string in CCConsole.
2014-04-09 13:21:27 +08:00
Darragh Coy 117f22d895 Tweak formatting and change spaces to tabs so indentation appears consistent on github. 2014-04-08 08:47:26 -07:00
Darragh Coy 0082900d10 Small dangling pointer tweak/fix to CCEventDispatcher
If cleaning a target node that has a listener in the 'to be added' listeners list then ensure that listener does not have a stale reference to the node. This is a minor tweak in addition to pull request 6160 (https://github.com/cocos2d/cocos2d-x/pull/6160).
2014-04-08 08:46:09 -07:00
Dhilan007 c378b42191 closed #4714:Fixed Cocos2dxHelper.runOnGLThread() can not work 2014-04-08 21:08:20 +08:00
shujunqiao 9391906738 modify const char* to std::string in CCConsole. 2014-04-08 18:20:06 +08:00
shujunqiao 11af83dbf6 [ci skip], add get package size in cocos-console-test.py. 2014-04-08 18:02:12 +08:00
minggo 6208943cb1 Merge pull request #6168 from heliclei/fix-console-upload
closed #4533:fix console upload hang issue
2014-04-08 17:55:15 +08:00
minggo e2252cafe3 Merge pull request #6174 from minggo/change-to-private
change QuadCommand::generateMaterialID() to private
2014-04-08 17:54:36 +08:00
minggo ccbd77309d change QuadCommand::generateMaterialID() to private 2014-04-08 17:49:18 +08:00
James Chen 02507ce25f Merge pull request #6173 from lmskater/fix-git-fail-return-value
[Jenkins][ci skip]: Modified the return value when git fails, it's used for `ci rebuild`
2014-04-08 17:32:31 +08:00
minggo 0c2b654410 Merge pull request #6171 from minggo/iss4683-assert_not_thread_safe
use assert because CCASSERT is not thread safe
2014-04-08 17:16:28 +08:00
Huabing.Xu 7f1fb13113 closed #4629: remove unused _renderStack 2014-04-08 16:54:00 +08:00
lm ca9b4a3196 [Jenkins][ci skip]: Fix return value of git fail 2014-04-08 16:35:01 +08:00
minggo b1d4821988 Merge pull request #6172 from natural-law/issue4666
Optimize the configuration of copy resources files in templates.
2014-04-08 16:33:37 +08:00
zhangbin 99f7ca5c40 Merge branch 'develop' of https://github.com/cocos2d/cocos2d-x into issue4666 2014-04-08 16:27:18 +08:00
zhangbin 12fb27b01e closed #4666, Update the build configuration files in template & update the reference of submodule cocos2d-console. 2014-04-08 16:23:12 +08:00
James Chen 87a3b7e6cb Update AUTHORS [ci skip] 2014-04-08 15:50:26 +08:00
James Chen e1f2b71429 Merge pull request #6161 from DarraghCoy/check_node_not_running_when_destroyed
Adding extra CCNode verification in Node's destructor
2014-04-08 15:49:22 +08:00
James Chen 0db1bbdf68 Merge pull request #6167 from shujunqiao/testcpp-shader
delete ShaderFail sample in ShaderTest.cpp. It's needed for `autotest`.
2014-04-08 15:47:01 +08:00
James Chen 2d3cb82816 Update CHANGELOG [ci skip] 2014-04-08 15:45:18 +08:00
James Chen 2703740acd Update AUTHORS [ci skip] 2014-04-08 15:43:38 +08:00
James Chen 28ebec46dc Merge pull request #6151 from mgcL/ScriptHandlerMgr-memory-free
add destroyInstance for ScriptHandlerMgr
2014-04-08 15:41:18 +08:00
James Chen b0c0d1e82b Merge pull request #6165 from natural-law/develop
Update the reference of submodule plugin-x
2014-04-08 15:37:24 +08:00
James Chen 5df765ef0c Merge pull request #6169 from dumganhar/iss4710-eventdispatcher-crash
closed #4710: [win32] Crash in EventDispatcher if game starts up with mouse moving frequently
2014-04-08 15:31:52 +08:00
James Chen ec6714cc82 Merge pull request #6170 from dumganhar/iss4711-fileexist-win32
closed #4711: [win32] Passing empty string to FileUtils::isFileExist may also return true
2014-04-08 15:31:17 +08:00
James Chen e04b820cfc closed #4711: [win32] Passing empty string to FileUtils::isFileExist may also return true 2014-04-08 15:24:47 +08:00
James Chen 8f451d48a1 issue #4710: Fixed wrong indention. 2014-04-08 15:11:04 +08:00
James Chen 49bba30409 closed #4710: [win32] Crash in EventDispatcher if game starts up with mouse moving frequently 2014-04-08 15:08:34 +08:00
minggo e28093ee1a closed #4683: use assert because CCASSERT is not thread safe 2014-04-08 14:53:57 +08:00
heliclei 4e1284bd45 closed #4533:fix console upload hang issue 2014-04-08 14:52:53 +08:00
shujunqiao fb777b1a1d [ci skip], delete ShaderFail sample in ShaderTest.cpp. 2014-04-08 14:52:17 +08:00
shujunqiao fae742c0b8 modify ShaderTest.cpp not crah to autotest. 2014-04-08 14:32:25 +08:00
zhangbin a2e4aeb857 Update the reference of submodule plugin-x 2014-04-08 14:31:21 +08:00
James Chen 0834c07fa3 Update CHANGELOG [ci skip] 2014-04-08 11:37:00 +08:00
James Chen ecf784646d Update AUTHORS [ci skip] 2014-04-08 11:34:01 +08:00
heliclei 798708f775 fix autotest touch hang:run test scene constructor in cocos thread 2014-04-08 11:29:42 +08:00
James Chen c2b8557efb Merge pull request #6162 from dumganhar/pull/6160
Fixed a potential crash in EventDispatcher, based on PR #6160
2014-04-08 11:25:59 +08:00
James Chen 546db2de4a Unregistered listener when it's removed from _toAddedListeners. 2014-04-08 11:17:38 +08:00
Darragh Coy 9a6b93eae1 Add extra CCNode verification
Add a check to the CCNode destructor to catch a common cocos2d-x programming mistake - forgetting to call base class onExit() in derived class onExit() implementations. We can check for this invalid API usage by checking if the node is still marked as running on destruction. If the node still thinks it's running then it's likely the cleanup logic performed by Node::onExit() was not done.
2014-04-07 17:05:42 -07:00
Darragh Coy bb85df66b1 Add an event dispatcher test
Add an event dispatcher test to help reproduce crashes fixed by the previous commit and to verify that the fix still works.
2014-04-07 16:46:03 -07:00
Darragh Coy 79b5dff795 CCEventDispatcher crash fix
Fix possible crashes which could be caused by the EventDispatcher having listeners associated with nodes are destroyed. Catch the case where a node registers a listener while we are dispatching events and gets destroyed while that event is still being dispatched. Check the list of nodes to be added into the event dispatcher fully when we are cleaning listeners for a target node.

This issue was found using the extra debug verification in this pull request:
https://github.com/cocos2d/cocos2d-x/pull/6011
2014-04-07 16:19:26 -07:00
Huabing.Xu 1a7f46598f closed #4629: fix bug for group command 2014-04-07 22:51:32 +08:00
Huabing.Xu 1b0c55ef15 issue #4629: test case add a spriteInGroup instead of sprite, the sprite can not be seen now 2014-04-07 22:31:24 +08:00
Huabing.Xu beda294be1 issue #4629: add test case for group command 2014-04-07 22:02:43 +08:00
James Chen f9ac3c82fc Update CHANGELOG [ci skip] 2014-04-07 16:34:56 +08:00
James Chen cdb68cc918 Update AUTHORS [ci skip] 2014-04-07 16:33:40 +08:00
James Chen 1b85be2b9b Merge pull request #6150 from mgcL/Value-memory-leak
A potential memory leak in value's default constructor.
2014-04-07 16:32:01 +08:00
James Chen 0d8c70e93f Update AUTHORS [ci skip] 2014-04-07 16:20:47 +08:00
James Chen cd2a74d4ec Merge pull request #6156 from zakmandhro/patch-1
A typo fix in RELEASE_NOTES.md
2014-04-07 16:19:38 +08:00