Out of range occurred in some condition
when using `Label` with its `getLetter()` member function.
`Label::recordPlaceholderInfo()` member function is called for
new line (\n) letter in `Label::multilineTextWrap()`,
but the function doesn't set `_lettersInfo[letterIndex].lineIndex`.
But `lineIndex` is used in `Label::updateLabelLetters()`
even if letter is new line.
This change checks `letterInfo.valid` to avoid
accessing `_linesOffsetX[letterInfo.lineIndex]`
for invalid (i.e. `NewLine`) letter.
This factory method to create a checkbox instance was not working (UICheckBox.cpp:79):
CheckBox* CheckBox::create(const std::string& backGround,
const std::string& cross,
TextureResType texType)
Because the program tries to load missing textures. I just added some exit conditions to avoid it.
* use atomic_bool type for _isRotateThreadExited
* add test case for issues 18597
* fix test case error
* add data race comments, fix lock usage error
* add comments for audioplayer
* fix typo in comments
* revert wrong changes
* update test case, keep reproduce
* add alSourceUnqueueBuffers before stop
* improve UnqueueBuffers
* detail test case to show side effect
* remove unused comments
* add comments for AudioPlayer change
* correct a audio log level
* change log level from W to VV
* update time step, add play state check
* remove record time of UnqueueBuffers
* [UIRichText.cpp] Allow user to select if they want to trim trailing spaces for a RichElementText. Also fixed crash if estimatedIdx is less than 0 in certain conditions.
[UIRichText.h] New flag added for enabling trailing space trimming.
[CCLabelTextFormatter.cpp] Only trim trailing whitespace if lines are being split. This will trim all whitespace up to the next non-whitespace token in a line.
* Fix for oversized sprites that need to be offset by X and Y to be aligned correctly in the UIRichText
* Revert "Fix for oversized sprites that need to be offset by X and Y to be aligned correctly in the UIRichText"
This reverts commit fc5492e878a982ff748488bf1de4ffa88a3d4755.
* [UIRichText] Reverted changes made for trimming since they are no longer required. The changes made to CCLabelTextFormatter.cpp fixed all the current issues.
* Added test cases from #18869
* Removed the forced trailing space clipping since it is not required here, and causing side-effects.
* Removed comment that no longer applies to that section of code
An old hack that changed the default order of included headers in ZipUtils causes issues when compiling cocos2d for Android 64-bit, throwing errors of missing `fgetpos` and `fsetpos` functions.
* Add GLViewImpl::setIcon and GLViewImpl::setDefaultIcon for windows and linux
* Include CCImage.h only if required
* Fix empty icon image
* Fix windows build
* [skip ci] Replace `{ return; }` with `{}`
* Add icon test to cpp-empty-test
* [skip ci] Replace TABs with spaces, add comments
* Chnage requested things, fix formatting
* Fix define
* Fix ios build
* ARCH_DIR only useful for search linux prebuilt libs
* add iOS app target ONLY_ACTIVE_ARCH property
* set Xcode property for application, include all depend target
* fix bugs-editbox-win32 crash
* improve EditBox-align test case
* typo error
* update cocos-console submodule
* VS RelWithDebInfo build use release folder external libs
* update edit box H alignment case
* improve label no-break-space test case
* fix label test cases bug
* add GetterSetter define for the placeHolder of TextField
* fix event condition bugs on ParticleTest.lua
* Added non-breaking character check function
* Check for non-breaking characters in words when formatting label text
* Added nbsp again as space character (removed in previous PR https://github.com/cocos2d/cocos2d-x/pull/18147)
* fix mistake for ios lua template
* auto select headers depend on sources
* change cmake "cocos_build_app" from macro to function
* fix cmake dll repeat copy
* update travis srcipt
* add header list for cocos lib
* add header list in cmake files
* re-add include dir Classes
* improve template cpp var name
* remove func get_headers_by_sources
* cmake add simulator header list
* make source and header collect more clear
* improve macos app pkg
* improve ios pkg, run failed
* revert the ios pak logic, keep older
* expand var APP_BIN_DIR scope
* fix use sqlite3 error on linux
* fix win32 compile error
* remove multi-add mistake
* try to fix python install issue on travis
* fix js-tests build on android
* uninstall old python in travis
* add travis python print info
* fix command ll to ls -l
* remove useless link
* PYTHON_BIN adapt homebrew python
In some situations, breakText() can return 0, which leads to an infinite
loop. In that case we just increase the index so the measuring doesn't
get stuck.
tyfkda